Uphall, Lothian born outside right Archie Brash began his football career with St Mirren in 1892, where he scored 17 goals in 37 appearances for The Buddies before being transferred to Sheffield Wednesday in July 1894. He made his Football League debut at Everton that September and played in the 1895 FA Cup semi final when Wednesday were beaten 2-0 by West Bromwich Albion at The County Ground, Derby.
The following season Brash went one better, being a member of Wednesday’s team that won the 1896 FA Cup Final when they beat Wolverhampton Wanderers 2-1 at The Crystal Palace. Brash had two further seasons at Hillsborough before a move to Crewe Alexandra in 1898, but returned to The Owls in 1899, who had been relegated in his absence, helping them to win The Second Division Championship in 1900 for a return to the top flight at the first time of asking.
He left the club in the summer of 1900 to join Leicester Fosse, signing for £110, having scored 26 goals in 131 appearances over his two spells with The Wednesday, and he scored 5 goals in 14 appearances for The Fossils during a single season at Filbert Street in 1900-01, where he failed to live up to expectations. He finally returned to Scotland to join Aberdeen in the 1901 close season where he retired in 1902 having made 15 appearances for The Dons.