Bannockburn, Stirlingshire born left back David Taylor started his football at junior club Bannockburn in 1904 and played for Glasgow Ashfield in 1906 from where he joined Glasgow Rangers the same year, making his Scottish League debut against Hearts in September 1906, also having a loan spell at Motherwell in 1909, but he struggled to gain regular football at Ibrox, playing only 28 games between 1906 and 1910. He moved to First Division Bradford City in 1910 and made his Football League debut at Sunderland in October 1910, most notably he was part of their successful 1911 FA Cup Final winning team which beat Newcastle in a replay. However after 51 games at City he moved in December that year to Burnley.
He stayed at Burnley until 1924 being part of their 1914 FA Cup Final team which beat Liverpool 1-0 at The Crystal Palace and also their 1921 League Championship winning team, scoring 5 times in 250 appearances for The Clarets over his career at Turf Moor before retirement in 1924. During the First World War he had loan spells at Ayr, Rangers where he played one further match in April 1916, Falkirk and Celtic, playing 5 games for the Hoops in 1919. After retirement from playing he enjoyed spells as manager of St Johnstone from 1924 to 1931, Dunfermline Athletic from 1936 to April 1938 and finally with Carlisle United from April 1938 to September 1939 and the outbreak of World War Two, which saw him leave Carlisle and the professional game.