Dumbarton, Dunbartonshire born centre forward David McKinley started his football career with Dumbarton Harp from where he moved to Aberdeen in May 1906. He made his Aberdeen debut against Queen’s Park in September 1906, scoring 5 goals in 20 appearances before joining Southern League Watford in August 1908. His Hornets debut came in a 2-0 away win at Queen’s Park Rangers in September 1908, and during his single season at Cassio Road he scored 6 goals in 26 appearances. He joined Pontypridd in the 1909 close season, playing a season before moving to Aberdare Athletic in October 1910. After 2 seasons in mid Wales he joined Rochdale in the close season of 1912 where he finished his career.