Greenock, Renfrewshire born played junior football for Britannia’s FC and may have had a spell with Linfield in Belfast before joining Partick Thistle in May 1897. From there he headed to England joining Jarrow in August 1898, and from there he was signed by First Division Everton in February 1900, making his Football League debut against Blackburn Rovers at the end of March 1900. He scored 6 goals in 23 appearances for The Toffees before joining Southern League Southampton in May 1901, but despite 5 goals in 5 appearances for The Saints was allowed to join West Ham United the same December for £20. His stay at West Ham was even shorter and having scored twice in 4 appearances, both goals coming on his debut in a 2-0 home win over Bristol Rovers on 21st December 1901, he joined Portsmouth in March 1902, where despite 7 goals in 7 Southern League outings he was again allowed to move on, this time to Wellingborough in 1903.
He had 2 full seasons in Northamptonshire, scoring 11 goals in 60 appearances, before joining Luton Town in the close season of 1905, where he again enjoyed a 2 season spell, scoring 10 goals in 42 appearances. He then joined Croydon Common in November 1907, where he scored 14 goals in 38 matches before returning to Luton Town in 1910, appearing just once more for The Hatters before retirement.