Inverness born inside left Tommy McDonald served in the Royal Horse Artillery during the First World War.and joined Inverness Thistle after the War, transferring to Glasgow Rangers in 1920, making his Scottish League debut at Clyde that December, one 2 appearances for Rangers. In March 1921 he moved to St James’ Park and spent a decade at Newcastle United, making his Football League debut a few days later at Middlesbrough and scoring his first Newcastle goal at Blackburn Rovers two weeks later.
He immediately established himself as a first choice forward for The Magpies, scoring a hat-trick in a win over Manchester City in April 1922, then winning the FA Cup with them in 1924 when he scored 3 times on the road to Wembley which saw them beat Aston Villa 2-0 in the Final at Wembley. He only missed one match, scoring a career best 23 goals, as Newcastle, by now with talisman Hughie Gallacher, won the League Championship in 1926-27, with only Gallacher outscoring him. His total that season included hat-tricks against Cardiff City and Notts County in an FA Cup tie.
He lost his place in September 1930 and by the time he played his final game for The Toon at Grimsby Town in January 1931 he had scored 113 goals in 367 appearances for Newcastle United. He joined York City in May 1931, scoring a dozen goals in 77 appearances in the early 1930’s, also playing for Midland League club Goole Town in 1933 – he rejoined York City in 1934 and made his final appearance for them in March 1935 – and joined non league Usworth Colliery later in 1935 before hanging up his boots already aged over 40.